Github user cwestin commented on a diff in the pull request:
https://github.com/apache/drill/pull/163#discussion_r40023098
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/memory/TestAllocators.java
---
@@ -63,6 +63,29 @@
private final static String planFile="/physical_allocator_test.json";
@Test
+ public void testTransfer() throws Exception {
+ final Properties props = new Properties() {
+ {
+ put(ExecConstants.TOP_LEVEL_MAX_ALLOC, "1000000");
+ put(ExecConstants.ERROR_ON_MEMORY_LEAK, "true");
+ }
+ };
+ final DrillConfig config = DrillConfig.create(props);
+ BufferAllocator a = new TopLevelAllocator(config);
--- End diff --
I was surprised this compiled; in one of my recent patches, I had removed
the "public" from TopLevelAllocator, but it seems to have come back. It was
removed to force people to use RootAllocatorFactory.newRoot() instead of using
the TopLevelAllocator constructor directly. Can you please remove the public
from TopLevelAllocator again, and replace this constructor here and on the next
line with RootAllocatorFactory.newRoot()?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
