----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38036/#review101062 -----------------------------------------------------------
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/RestServerHelper.java (line 59) <https://reviews.apache.org/r/38036/#comment158376> Can we change this to be an instance class. Let's call it DrillRestServer and make it AutoCloseable. Then all state can be internal. We just need to pass in the required configuration information. That way org.eclipse.jetty.server.Server is only held internally. In addition to comment above, can you confirm what will happen if a user tries to go to http://drillbit:8047? We should try to make that experience seamless. Is there a way to do that (basically redirect them to https://drillbit:8047) Beyond those changes, +1 - Jacques Nadeau On Sept. 2, 2015, 12:57 a.m., Venki Korukanti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38036/ > ----------------------------------------------------------- > > (Updated Sept. 2, 2015, 12:57 a.m.) > > > Review request for drill and Jacques Nadeau. > > > Bugs: DRILL-3725 > https://issues.apache.org/jira/browse/DRILL-3725 > > > Repository: drill-git > > > Description > ------- > > See DRILL-3725 for details. > > > Diffs > ----- > > distribution/src/resources/drill-override-example.conf 805d6e9 > exec/java-exec/pom.xml 601f5ca > exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java > 140e9a8 > exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java > 3862cea > > exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/RestServerHelper.java > PRE-CREATION > pom.xml 8d4b318 > > Diff: https://reviews.apache.org/r/38036/diff/ > > > Testing > ------- > > Manual testing. Working on adding tests for Web interface (DRILL-2965). > > > Thanks, > > Venki Korukanti > >
