Github user jaltekruse commented on a diff in the pull request:
https://github.com/apache/drill/pull/181#discussion_r40963410
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/BaseRepeatedValueVector.java
---
@@ -123,6 +123,15 @@ public int getBufferSize() {
}
@Override
+ public int getBufferSizeFor(int valueCount) {
+ if (getAccessor().getValueCount() == 0) {
+ return 0;
+ }
+
+ return offsets.getBufferSizeFor(valueCount) +
vector.getBufferSizeFor(valueCount);
--- End diff --
This first one should be passed valueCount +1 right? As was done in
VariableLengthVectors.java
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---