So far we have not been able to determine what is making the test intermittently fail. I have pulled the core changes out of the branch and I am running a final build to verify them with the existing tests. As this is code that wasn't being tested previously I don't anticipate any issues, and should be pushing shortly (for real this time).
I will make sure that we have the new tests stabilized and merged soon after the release. - Jason On Wed, Oct 7, 2015 at 2:33 PM, Jacques Nadeau <jacq...@dremio.com> wrote: > Splitting out the integration tests makes sense if they are causing > conflicts. Lets just get them merged asap after the release. > > -- > Jacques Nadeau > CTO and Co-Founder, Dremio > > On Wed, Oct 7, 2015 at 2:28 PM, Jason Altekruse <altekruseja...@gmail.com> > wrote: > > > Unfortunately the complete build is still having issues, although I can > get > > the specific module where the tests were added to run just fine. > > > > I'm going to try to figure it out ASAP, but if I cannot get the full > tests > > running it won't make sense to merge the patch as is. > > > > Would there be any objections to merging just the changes to the jdbc > > plugin that fix the known issues (and have been verified against MySQL) > and > > working on merging the new integration tests after the release? > > > > On Wed, Oct 7, 2015 at 1:52 PM, Jason Altekruse < > altekruseja...@gmail.com> > > wrote: > > > > > Hey Everyone, > > > > > > I ran into an issue testing the JDBC patch from Andrew. After a little > > > investigation I managed to find a fix for it, just a small change in > the > > > pom configuration for the new integration tests. > > > > > > I am doing one final run of the full unit tests and will push his > changes > > > soon (~30 mins) if it is successful. > > > > > > - Jason > > > > > > On Wed, Oct 7, 2015 at 1:46 PM, Aditya <adityakish...@gmail.com> > wrote: > > > > > >> I am planning to merge patch for DRILL-3888 to enable maven test > > artifacts > > >> for all modules. > > >> > > >> On Wed, Oct 7, 2015 at 1:06 PM, Abdel Hakim Deneche < > > >> adene...@maprtech.com> > > >> wrote: > > >> > > >> > Ok, let's cancel this release candidate and do another one once we > get > > >> the > > >> > required fixes in master. > > >> > > > >> > So far the only issue left to fix for 1.2.0 is Andrew's Jdbc storage > > >> fix ? > > >> > > > >> > Thanks > > >> > > > >> > On Wed, Oct 7, 2015 at 10:49 AM, Steven Phillips <ste...@dremio.com > > > > >> > wrote: > > >> > > > >> > > I don't think there is one yet. But I think there will be a jira > > along > > >> > with > > >> > > a fix coming shortly from Andrew. > > >> > > > > >> > > On Wed, Oct 7, 2015 at 10:46 AM, Abdel Hakim Deneche < > > >> > > adene...@maprtech.com> > > >> > > wrote: > > >> > > > > >> > > > Steven, what is the JIRA number for the jdbc storage issue ? > > >> > > > > > >> > > > Thanks > > >> > > > > > >> > > > On Wed, Oct 7, 2015 at 10:41 AM, Steven Phillips < > > ste...@dremio.com > > >> > > > >> > > > wrote: > > >> > > > > > >> > > > > There is also the jdbc storage issue, which Andrew says he > has a > > >> fix > > >> > > for. > > >> > > > > It's just a packaging problem, but given that it's one of the > > main > > >> > > > features > > >> > > > > of this release, I think it's important to get in. > > >> > > > > > > >> > > > > On Wed, Oct 7, 2015 at 10:39 AM, Abdel Hakim Deneche < > > >> > > > > adene...@maprtech.com> > > >> > > > > wrote: > > >> > > > > > > >> > > > > > sorry, I meant is DRILL-3901 a must have for 1.2.0 ? > > >> > > > > > > > >> > > > > > On Wed, Oct 7, 2015 at 10:37 AM, Abdel Hakim Deneche < > > >> > > > > > adene...@maprtech.com> > > >> > > > > > wrote: > > >> > > > > > > > >> > > > > > > the only way to include any new fixes into 1.2.0 is to > sink > > >> the > > >> > > > current > > >> > > > > > > release candidate and start another one. > > >> > > > > > > > > >> > > > > > > is DRILL-3892 a must have for 1.2.0 ? > > >> > > > > > > > > >> > > > > > > Thanks > > >> > > > > > > > > >> > > > > > > On Wed, Oct 7, 2015 at 10:29 AM, Aman Sinha < > > >> asi...@maprtech.com > > >> > > > > >> > > > > wrote: > > >> > > > > > > > > >> > > > > > >> DRILL-3901 patch is merged and I took the liberty to mark > > it > > >> for > > >> > > > 1.2.0 > > >> > > > > > but > > >> > > > > > >> will leave it up to the release manager to decide how to > > >> > > incorporate > > >> > > > > it. > > >> > > > > > >> I > > >> > > > > > >> also strongly feel that DRILL-3892 (incorrectly reported > > >> status > > >> > of > > >> > > > > > >> metadata > > >> > > > > > >> cache *not* being used when in fact it was used) should > be > > >> > > included > > >> > > > in > > >> > > > > > 1.2 > > >> > > > > > >> . > > >> > > > > > >> > > >> > > > > > >> On Wed, Oct 7, 2015 at 8:58 AM, Jacques Nadeau < > > >> > > jacq...@dremio.com> > > >> > > > > > >> wrote: > > >> > > > > > >> > > >> > > > > > >> > We're seeing an issue around the JDBC plugin. We're > still > > >> > > > debugging > > >> > > > > > but > > >> > > > > > >> it > > >> > > > > > >> > might also warrant a fix for the release. Updates soon. > > >> > > > > > >> > > > >> > > > > > >> > -- > > >> > > > > > >> > Jacques Nadeau > > >> > > > > > >> > CTO and Co-Founder, Dremio > > >> > > > > > >> > > > >> > > > > > >> > On Tue, Oct 6, 2015 at 11:45 AM, Aman Sinha < > > >> > > asi...@maprtech.com> > > >> > > > > > >> wrote: > > >> > > > > > >> > > > >> > > > > > >> > > I have filed DRILL-3901 for a performance issue that > we > > >> are > > >> > > > trying > > >> > > > > > to > > >> > > > > > >> > > address. We can discuss whether to continue with the > > >> > existing > > >> > > > > > release > > >> > > > > > >> > > candidate or wait for a fix. > > >> > > > > > >> > > > > >> > > > > > >> > > On Tue, Oct 6, 2015 at 9:38 AM, Edmon Begoli < > > >> > > ebeg...@gmail.com > > >> > > > > > > >> > > > > > >> wrote: > > >> > > > > > >> > > > > >> > > > > > >> > > > Humbly, +1. > > >> > > > > > >> > > > > > >> > > > > > >> > > > On Tue, Oct 6, 2015 at 12:32 PM, Abdel Hakim > Deneche > > < > > >> > > > > > >> > > > adene...@maprtech.com> > > >> > > > > > >> > > > wrote: > > >> > > > > > >> > > > > > >> > > > > > >> > > > > verified the artifacts checksums and that they > are > > >> > signed > > >> > > by > > >> > > > > my > > >> > > > > > >> gpg > > >> > > > > > >> > > key. > > >> > > > > > >> > > > > Built Drill from source in MacOS and CentOS and > > both > > >> > > builds > > >> > > > > were > > >> > > > > > >> > > > successful > > >> > > > > > >> > > > > and all unit tests passed. Run some window > > functions > > >> > > queries > > >> > > > > and > > >> > > > > > >> > > > everything > > >> > > > > > >> > > > > seems fine. > > >> > > > > > >> > > > > > > >> > > > > > >> > > > > +1 (binding) > > >> > > > > > >> > > > > > > >> > > > > > >> > > > > On Mon, Oct 5, 2015 at 1:59 PM, Abdel Hakim > > Deneche < > > >> > > > > > >> > > > adene...@maprtech.com > > >> > > > > > >> > > > > > > > >> > > > > > >> > > > > wrote: > > >> > > > > > >> > > > > > > >> > > > > > >> > > > > > Aman, I used JIRA release notes generator. It > > >> includes > > >> > > all > > >> > > > > > JIRAs > > >> > > > > > >> > > marked > > >> > > > > > >> > > > > > "Fix for" 1.2.0. I guess we just need to move > all > > >> > JIRAs > > >> > > > > still > > >> > > > > > >> open > > >> > > > > > >> > > and > > >> > > > > > >> > > > > > marked as 1.2.0 to 1.3.0 or Future. > > >> > > > > > >> > > > > > > > >> > > > > > >> > > > > > On Mon, Oct 5, 2015 at 1:54 PM, Aman Sinha < > > >> > > > > > asi...@maprtech.com > > >> > > > > > >> > > > >> > > > > > >> > > > wrote: > > >> > > > > > >> > > > > > > > >> > > > > > >> > > > > >> I see the following in the release notes: > this > > is > > >> > not > > >> > > > > > >> supported > > >> > > > > > >> > > yet. > > >> > > > > > >> > > > > Are > > >> > > > > > >> > > > > >> you using the correct 'status' condition in > your > > >> > query > > >> > > ? > > >> > > > > > >> > > > > >> > > >> > > > > > >> > > > > >> - [DRILL-3534 < > > >> > > > > > >> > https://issues.apache.org/jira/browse/DRILL-3534 > > >> > > > > > >> > > >] > > >> > > > > > >> > > > - > > >> > > > > > >> > > > > >> Insert into table support > > >> > > > > > >> > > > > >> > > >> > > > > > >> > > > > >> > > >> > > > > > >> > > > > >> On Mon, Oct 5, 2015 at 1:16 PM, Abdel Hakim > > >> Deneche < > > >> > > > > > >> > > > > >> adene...@maprtech.com> > > >> > > > > > >> > > > > >> wrote: > > >> > > > > > >> > > > > >> > > >> > > > > > >> > > > > >> > One precision, the commit that should show > up > > in > > >> > the > > >> > > > > > release > > >> > > > > > >> is > > >> > > > > > >> > > the > > >> > > > > > >> > > > > >> > following: > > >> > > > > > >> > > > > >> > > > >> > > > > > >> > > > > >> > b418397790e7e00505846d48bc6458d710c00095 > > >> > > > > > >> > > > > >> > upgrading maven-release plugin to fix > release > > >> > issues > > >> > > > > > >> > > > > >> > > > >> > > > > > >> > > > > >> > master has already moved past that commit > > >> > > > > > >> > > > > >> > > > >> > > > > > >> > > > > >> > thanks > > >> > > > > > >> > > > > >> > > > >> > > > > > >> > > > > >> > On Mon, Oct 5, 2015 at 11:00 AM, Abdel Hakim > > >> > Deneche > > >> > > < > > >> > > > > > >> > > > > >> > adene...@maprtech.com> > > >> > > > > > >> > > > > >> > wrote: > > >> > > > > > >> > > > > >> > > > >> > > > > > >> > > > > >> > > Hey all, > > >> > > > > > >> > > > > >> > > > > >> > > > > > >> > > > > >> > > I'm happy to propose a new release of > Apache > > >> > Drill, > > >> > > > > > version > > >> > > > > > >> > > 1.2.0. > > >> > > > > > >> > > > > >> This > > >> > > > > > >> > > > > >> > is > > >> > > > > > >> > > > > >> > > the first release candidate (rc0). > > >> > > > > > >> > > > > >> > > > > >> > > > > > >> > > > > >> > > Thanks to everyone who contributed to this > > >> > release, > > >> > > > we > > >> > > > > > have > > >> > > > > > >> > more > > >> > > > > > >> > > > > than > > >> > > > > > >> > > > > >> 200 > > >> > > > > > >> > > > > >> > > closed and resolved JIRAs > > >> > > > > > >> > > > > >> > > [1]. > > >> > > > > > >> > > > > >> > > > > >> > > > > > >> > > > > >> > > The tarball artifacts are hosted at [2] > and > > >> the > > >> > > maven > > >> > > > > > >> > artifacts > > >> > > > > > >> > > > (new > > >> > > > > > >> > > > > >> for > > >> > > > > > >> > > > > >> > > this release) are hosted at [3]. > > >> > > > > > >> > > > > >> > > > > >> > > > > > >> > > > > >> > > The vote will be open for the next 72 > hours > > >> > ending > > >> > > at > > >> > > > > > 11AM > > >> > > > > > >> > > > Pacific, > > >> > > > > > >> > > > > >> > > October 8, 2015. > > >> > > > > > >> > > > > >> > > > > >> > > > > > >> > > > > >> > > [ ] +1 > > >> > > > > > >> > > > > >> > > [ ] +0 > > >> > > > > > >> > > > > >> > > [ ] -1 > > >> > > > > > >> > > > > >> > > > > >> > > > > > >> > > > > >> > > thanks, > > >> > > > > > >> > > > > >> > > Hakim > > >> > > > > > >> > > > > >> > > > > >> > > > > > >> > > > > >> > > [1] > > >> > > > > > >> > > > > >> > > > > >> > > > > > >> > > > > >> > > > >> > > > > > >> > > > > >> > > >> > > > > > >> > > > > > > >> > > > > > >> > > > > > >> > > > > > >> > > > > >> > > > > > >> > > > >> > > > > > >> > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12332042&projectId=12313820 > > >> > > > > > >> > > > > >> > > [2] > > >> > > > > > >> > > > http://people.apache.org/~adeneche/apache-drill-1.2.0-rc0/ > > >> > > > > > >> > > > > >> > > [3] > > >> > > > > > >> > > > > >> > > > >> > > > > > >> > > > > > > >> > > > > > >> > > > >> > > > > > > > >> > > > > >> > https://repository.apache.org/content/repositories/orgapachedrill-1004 > > >> > > > > > >> > > > > >> > > -- > > >> > > > > > >> > > > > >> > > > > >> > > > > > >> > > > > >> > > Abdelhakim Deneche > > >> > > > > > >> > > > > >> > > > > >> > > > > > >> > > > > >> > > Software Engineer > > >> > > > > > >> > > > > >> > > > > >> > > > > > >> > > > > >> > > <http://www.mapr.com/> > > >> > > > > > >> > > > > >> > > > > >> > > > > > >> > > > > >> > > > > >> > > > > > >> > > > > >> > > Now Available - Free Hadoop On-Demand > > Training > > >> > > > > > >> > > > > >> > > < > > >> > > > > > >> > > > > >> > > > >> > > > > > >> > > > > >> > > >> > > > > > >> > > > > > > >> > > > > > >> > > > > > >> > > > > > >> > > > > >> > > > > > >> > > > >> > > > > > >> > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > > http://www.mapr.com/training?utm_source=Email&utm_medium=Signature&utm_campaign=Free%20available > > >> > > > > > >> > > > > >> > > > > >> > > > > > >> > > > > >> > > > > >> > > > > > >> > > > > >> > > > >> > > > > > >> > > > > >> > > > >> > > > > > >> > > > > >> > > > >> > > > > > >> > > > > >> > -- > > >> > > > > > >> > > > > >> > > > >> > > > > > >> > > > > >> > Abdelhakim Deneche > > >> > > > > > >> > > > > >> > > > >> > > > > > >> > > > > >> > Software Engineer > > >> > > > > > >> > > > > >> > > > >> > > > > > >> > > > > >> > <http://www.mapr.com/> > > >> > > > > > >> > > > > >> > > > >> > > > > > >> > > > > >> > > > >> > > > > > >> > > > > >> > Now Available - Free Hadoop On-Demand > Training > > >> > > > > > >> > > > > >> > < > > >> > > > > > >> > > > > >> > > > >> > > > > > >> > > > > >> > > >> > > > > > >> > > > > > > >> > > > > > >> > > > > > >> > > > > > >> > > > > >> > > > > > >> > > > >> > > > > > >> > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > > http://www.mapr.com/training?utm_source=Email&utm_medium=Signature&utm_campaign=Free%20available > > >> > > > > > >> > > > > >> > > > > >> > > > > > >> > > > > >> > > > >> > > > > > >> > > > > >> > > >> > > > > > >> > > > > > > > >> > > > > > >> > > > > > > > >> > > > > > >> > > > > > > > >> > > > > > >> > > > > > -- > > >> > > > > > >> > > > > > > > >> > > > > > >> > > > > > Abdelhakim Deneche > > >> > > > > > >> > > > > > > > >> > > > > > >> > > > > > Software Engineer > > >> > > > > > >> > > > > > > > >> > > > > > >> > > > > > <http://www.mapr.com/> > > >> > > > > > >> > > > > > > > >> > > > > > >> > > > > > > > >> > > > > > >> > > > > > Now Available - Free Hadoop On-Demand Training > > >> > > > > > >> > > > > > < > > >> > > > > > >> > > > > > > >> > > > > > >> > > > > > >> > > > > > >> > > > > >> > > > > > >> > > > >> > > > > > >> > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > > http://www.mapr.com/training?utm_source=Email&utm_medium=Signature&utm_campaign=Free%20available > > >> > > > > > >> > > > > > > > >> > > > > > >> > > > > > > > >> > > > > > >> > > > > > > >> > > > > > >> > > > > > > >> > > > > > >> > > > > > > >> > > > > > >> > > > > -- > > >> > > > > > >> > > > > > > >> > > > > > >> > > > > Abdelhakim Deneche > > >> > > > > > >> > > > > > > >> > > > > > >> > > > > Software Engineer > > >> > > > > > >> > > > > > > >> > > > > > >> > > > > <http://www.mapr.com/> > > >> > > > > > >> > > > > > > >> > > > > > >> > > > > > > >> > > > > > >> > > > > Now Available - Free Hadoop On-Demand Training > > >> > > > > > >> > > > > < > > >> > > > > > >> > > > > > > >> > > > > > >> > > > > > >> > > > > > >> > > > > >> > > > > > >> > > > >> > > > > > >> > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > > http://www.mapr.com/training?utm_source=Email&utm_medium=Signature&utm_campaign=Free%20available > > >> > > > > > >> > > > > > > > >> > > > > > >> > > > > > > >> > > > > > >> > > > > > >> > > > > > >> > > > > >> > > > > > >> > > > >> > > > > > >> > > >> > > > > > > > > >> > > > > > > > > >> > > > > > > > > >> > > > > > > -- > > >> > > > > > > > > >> > > > > > > Abdelhakim Deneche > > >> > > > > > > > > >> > > > > > > Software Engineer > > >> > > > > > > > > >> > > > > > > <http://www.mapr.com/> > > >> > > > > > > > > >> > > > > > > > > >> > > > > > > Now Available - Free Hadoop On-Demand Training > > >> > > > > > > < > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > > http://www.mapr.com/training?utm_source=Email&utm_medium=Signature&utm_campaign=Free%20available > > >> > > > > > > > > >> > > > > > > > > >> > > > > > > > >> > > > > > > > >> > > > > > > > >> > > > > > -- > > >> > > > > > > > >> > > > > > Abdelhakim Deneche > > >> > > > > > > > >> > > > > > Software Engineer > > >> > > > > > > > >> > > > > > <http://www.mapr.com/> > > >> > > > > > > > >> > > > > > > > >> > > > > > Now Available - Free Hadoop On-Demand Training > > >> > > > > > < > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > > http://www.mapr.com/training?utm_source=Email&utm_medium=Signature&utm_campaign=Free%20available > > >> > > > > > > > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > > >> > > > > > >> > > > -- > > >> > > > > > >> > > > Abdelhakim Deneche > > >> > > > > > >> > > > Software Engineer > > >> > > > > > >> > > > <http://www.mapr.com/> > > >> > > > > > >> > > > > > >> > > > Now Available - Free Hadoop On-Demand Training > > >> > > > < > > >> > > > > > >> > > > > >> > > > >> > > > http://www.mapr.com/training?utm_source=Email&utm_medium=Signature&utm_campaign=Free%20available > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > > >> > > > >> > -- > > >> > > > >> > Abdelhakim Deneche > > >> > > > >> > Software Engineer > > >> > > > >> > <http://www.mapr.com/> > > >> > > > >> > > > >> > Now Available - Free Hadoop On-Demand Training > > >> > < > > >> > > > >> > > > http://www.mapr.com/training?utm_source=Email&utm_medium=Signature&utm_campaign=Free%20available > > >> > > > > >> > > > >> > > > > > > > > >
