Github user jacques-n commented on a diff in the pull request:
https://github.com/apache/drill/pull/190#discussion_r41717923
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinTemplate.java
---
@@ -87,125 +42,68 @@ public void setupJoin(FragmentContext context,
JoinStatus status, VectorContaine
*/
public final boolean doJoin(final JoinStatus status) {
while(!status.isOutgoingBatchFull()) {
- // for each record
- // validate input iterators (advancing to the next record batch if
necessary)
- if (!status.isRightPositionAllowed()) {
+ if (status.rightFinished()) {
if
(((MergeJoinPOP)status.outputBatch.getPopConfig()).getJoinType() ==
JoinRelType.LEFT) {
--- End diff --
let's grab this property at the beginning of the join rather than each time
we doJoin.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
