Github user julianhyde commented on a diff in the pull request:
https://github.com/apache/drill/pull/193#discussion_r43316183
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/FindLimit0Visitor.java
---
@@ -46,6 +51,32 @@ public static boolean containsLimit0(RelNode rel) {
return visitor.isContains();
}
+ public static DrillRel addLimitOnTopOfLeafNodes(final DrillRel rel) {
+ final RelShuttleImpl shuttle = new RelShuttleImpl() {
+
+ private RelNode addLimitAsParent(RelNode node) {
+ final RexBuilder builder = node.getCluster().getRexBuilder();
+ final RexLiteral offset =
builder.makeExactLiteral(BigDecimal.ZERO);
+ final RexLiteral fetch = builder.makeExactLiteral(BigDecimal.ZERO);
+ return new DrillLimitRel(node.getCluster(), node.getTraitSet(),
node, offset, fetch);
--- End diff --
Agree with @jinfengni. In more recent versions of Calcite, use
RelBuilder.limit() or .sortLimit(). The RelBuilder will be configured to create
the appropriate Drill variants of all RelNodes. It might also do some useful
canonization/optimization. We recommend using RelBuilder for most tasks
involving creating RelNodes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
