Github user amithadke commented on a diff in the pull request:

    https://github.com/apache/drill/pull/214#discussion_r43462115
  
    --- Diff: 
exec/java-exec/src/test/java/org/apache/drill/exec/impersonation/TestImpersonationQueries.java
 ---
    @@ -179,6 +199,15 @@ private static void createView(final String viewOwner, 
final String viewGroup, f
         assertEquals(viewPerms, status.getPermission().toShort());
       }
     
    +  private static void createView(final String viewOwner, final String 
viewGroup, final String viewName,
    --- End diff --
    
    Other createView methods are part of TestImpersonationQueries so just 
wanted to be consistent. We can move them all to BaseTestImpersonation?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to