Github user jacques-n commented on a diff in the pull request:
https://github.com/apache/drill/pull/207#discussion_r43471716
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/ExpressionTreeMaterializer.java
---
@@ -187,14 +206,17 @@ private static void
logFunctionResolutionError(ErrorCollector errorCollector, Fu
private static class MaterializeVisitor extends
AbstractExprVisitor<LogicalExpression, FunctionLookupContext, RuntimeException>
{
private ExpressionValidator validator = new ExpressionValidator();
- private final ErrorCollector errorCollector;
+ private ErrorCollector errorCollector;
+ private Deque<ErrorCollector> errorCollectors = new ArrayDeque<>();
private final VectorAccessible batch;
private final boolean allowComplexWriter;
+ private final boolean unionTypeEnabled;
- public MaterializeVisitor(VectorAccessible batch, ErrorCollector
errorCollector, boolean allowComplexWriter) {
+ public MaterializeVisitor(VectorAccessible batch, ErrorCollector
errorCollector, boolean allowComplexWriter, boolean unionTypeEnabled) {
this.batch = batch;
this.errorCollector = errorCollector;
this.allowComplexWriter = allowComplexWriter;
+ this.unionTypeEnabled = unionTypeEnabled;
}
private LogicalExpression validateNewExpr(LogicalExpression newExpr) {
--- End diff --
can you add a javadoc please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
