Github user StevenMPhillips commented on a diff in the pull request:
https://github.com/apache/drill/pull/207#discussion_r43479756
--- Diff: exec/java-exec/src/main/codegen/templates/UnionVector.java ---
@@ -0,0 +1,479 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import org.apache.drill.common.types.TypeProtos.MinorType;
+
+<@pp.dropOutputFile />
+<@pp.changeOutputFile
name="/org/apache/drill/exec/vector/complex/impl/UnionVector.java" />
+
+
+<#include "/@includes/license.ftl" />
+
+package org.apache.drill.exec.vector.complex.impl;
+
+<#include "/@includes/vv_imports.ftl" />
+import java.util.Iterator;
+import org.apache.drill.exec.vector.complex.impl.ComplexCopier;
+import org.apache.drill.exec.util.CallBack;
+
+/*
+ * This class is generated using freemarker and the ${.template_name}
template.
+ */
+@SuppressWarnings("unused")
+
+
+public class UnionVector implements ValueVector {
+
+ private MaterializedField field;
+ private BufferAllocator allocator;
+ private Accessor accessor = new Accessor();
+ private Mutator mutator = new Mutator();
+ private int valueCount;
+
+ private MapVector internalMap;
+ private SingleMapWriter internalMapWriter;
+ private UInt1Vector typeVector;
+
+ private MapVector mapVector;
+ private ListVector listVector;
+ private NullableBigIntVector bigInt;
+ private NullableVarCharVector varChar;
+
+ private FieldReader reader;
+ private NullableBitVector bit;
+
+ private State state = State.INIT;
+ private int singleType = 0;
+ private ValueVector singleVector;
+ private MajorType majorType;
+
+ private final CallBack callBack;
+
+ private enum State {
+ INIT, SINGLE, MULTI
+ }
+
+ public UnionVector(MaterializedField field, BufferAllocator allocator,
CallBack callBack) {
+ this.field = field.clone();
+ this.allocator = allocator;
+ internalMap = new MapVector("internal", allocator, callBack);
+ internalMapWriter = new SingleMapWriter(internalMap, null, true, true);
+ this.typeVector = internalMap.addOrGet("types",
Types.required(MinorType.UINT1), UInt1Vector.class);
+ this.field.addChild(internalMap.getField().clone());
+ this.majorType = field.getType();
+ this.callBack = callBack;
+ }
+
+ private void updateState(ValueVector v) {
+ if (state == State.INIT) {
+ state = State.SINGLE;
+ singleVector = v;
+ singleType = v.getField().getType().getMinorType().getNumber();
+ } else {
+ state = State.MULTI;
+ singleVector = null;
+ }
+ }
+
+ public List<MinorType> getSubTypes() {
+ return majorType.getSubTypeList();
+ }
+
+ private void addSubType(MinorType type) {
+ majorType =
MajorType.newBuilder(this.majorType).addSubType(type).build();
+ if (callBack != null) {
+ callBack.doWork();
+ }
+ }
+
+ public boolean isSingleType() {
+ return state == State.SINGLE && singleType != MinorType.LIST_VALUE;
+ }
+
+ public ValueVector getSingleVector() {
+ assert state != State.MULTI : "Cannot get single vector when there are
multiple types";
--- End diff --
This State was originally designed to eliminate some of the overhead when
there was only a single subtype, but with PromotableWriter, this is really not
necessary, and this State is no longer used. So I removed this code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
