Github user hnfgns commented on a diff in the pull request:
https://github.com/apache/drill/pull/245#discussion_r44198946
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/validate/IteratorValidatorBatchIterator.java
---
@@ -33,36 +33,113 @@
import org.apache.drill.exec.util.BatchPrinter;
import org.apache.drill.exec.vector.VectorValidator;
+import static org.apache.drill.exec.record.RecordBatch.IterOutcome.*;
+
+
public class IteratorValidatorBatchIterator implements
CloseableRecordBatch {
- static final org.slf4j.Logger logger =
org.slf4j.LoggerFactory.getLogger(IteratorValidatorBatchIterator.class);
+ private static final org.slf4j.Logger logger =
+
org.slf4j.LoggerFactory.getLogger(IteratorValidatorBatchIterator.class);
static final boolean VALIDATE_VECTORS = false;
- private IterOutcome state = IterOutcome.NOT_YET;
+ /** For logging/debuggability only. */
+ private static volatile int instanceCount;
+
+ /** For logging/debuggability only. */
+ private final int instNum;
+ {
+ instNum = ++instanceCount;
--- End diff --
not thread-safe but not a show stopper since it is improving debugging
experience.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
