I just ran the tests on a linux machine, and did not see this failure. Do you see it consistently?
On Wed, Dec 2, 2015 at 10:20 PM, Jinfeng Ni <jinfengn...@gmail.com> wrote: > I run mvn full build on linux box against the latest master branch. > There was one unit test failure. However, on mac, it's successful. Has > anyone experienced the same? > > Failed tests: > TestCsvHeader.testCsvHeaderMismatch:151->validateResults:196 Result > mismatch. > Expected: > Year|Model|Category > 1999|Venture "Extended Edition"| > 1999|Venture "Extended Edition, Very Large"| > Year|Model|Category > 1999||Venture "Extended Edition" > 1999||Venture "Extended Edition, Very Large" > > Received: > Year|Model|Category > 1999||Venture "Extended Edition" > 1999||Venture "Extended Edition, Very Large" > Year|Model|Category > 1999|Venture "Extended Edition"| > 1999|Venture "Extended Edition, Very Large"| > expected:<...Model|Category > 1999|[Venture "Extended Edition"| > 1999|Venture "Extended Edition, Very Large"| > Year|Model|Category > 1999||Venture "Extended Edition" > 1999||Venture "Extended Edition, Very Large"] > > but was:<...Model|Category > 1999|[|Venture "Extended Edition" > 1999||Venture "Extended Edition, Very Large" > Year|Model|Category > 1999|Venture "Extended Edition"| > 1999|Venture "Extended Edition, Very Large"|] > > > > Tests run: 1505, Failures: 1, Errors: 0, Skipped: 121 > > git log > commit 3ae3bf5e127b4384c7b91d797d36ea4d51a058ae > > > On Wed, Dec 2, 2015 at 7:21 PM, Jacques Nadeau <jacq...@dremio.com> wrote: > > I think we should roll forward to 1.5-S.. > > On Dec 2, 2015 6:44 PM, "Venki Korukanti" <venki.koruka...@gmail.com> > wrote: > > > >> 1.4.0 branch is cut and available here: > >> https://github.com/vkorukanti/drill/tree/1.4.0. > >> > >> Should I move the master to 1.5.0-SNAPSHOT now or wait until an RC is > >> passed? > >> > >> Thanks > >> Venki > >> > >> On Wed, Dec 2, 2015 at 4:25 PM, Venki Korukanti < > venki.koruka...@gmail.com > >> > > >> wrote: > >> > >> > For DRILL-4109 and DRILL-4125, Vicky is not available today to > verify. If > >> > the changes are reviewed lets merge them today. Once the branch is cut > >> > today, MapR will do the release sanity for next couple of days before > RC0 > >> > voting goes out. If any issues are found, we still have time to fix > >> before > >> > the RC0 voting. > >> > > >> > Thanks > >> > Venki > >> > > >> > On Wed, Dec 2, 2015 at 4:02 PM, Jacques Nadeau <jacq...@dremio.com> > >> wrote: > >> > > >> >> Sounds good. > >> >> > >> >> -- > >> >> Jacques Nadeau > >> >> CTO and Co-Founder, Dremio > >> >> > >> >> On Wed, Dec 2, 2015 at 2:47 PM, Steven Phillips <ste...@dremio.com> > >> >> wrote: > >> >> > >> >> > Okay, I'm going to go ahead and merge DRILL-4145 > >> >> > > >> >> > On Wed, Dec 2, 2015 at 2:45 PM, Venki Korukanti < > >> >> venki.koruka...@gmail.com > >> >> > > > >> >> > wrote: > >> >> > > >> >> > > For DRILL-4145: ran the regression suite which includes customer > and > >> >> > > extended tests. No regressions found. > >> >> > > > >> >> > > On Wed, Dec 2, 2015 at 1:41 PM, Venki Korukanti < > >> >> > venki.koruka...@gmail.com > >> >> > > > > >> >> > > wrote: > >> >> > > > >> >> > > > Sure, I will trigger a regression run with DRILL-4145. > >> >> > > > > >> >> > > > Thanks > >> >> > > > Venki > >> >> > > > > >> >> > > > On Wed, Dec 2, 2015 at 1:36 PM, Jacques Nadeau < > >> jacq...@dremio.com> > >> >> > > wrote: > >> >> > > > > >> >> > > >> I believe 4109 is ready but if I understand correctly, it > can't > >> go > >> >> in > >> >> > > >> without 4125. Amit said he needs another hour for that. > >> >> > > >> > >> >> > > >> On 4145: Venki, can someone on your side running any > >> >> extended/customer > >> >> > > >> tests you have against this to make sure that it doesn't cause > >> any > >> >> > > >> regressions. We've run on our side without issue but I'd like > to > >> >> get > >> >> > as > >> >> > > >> broad of coverage as possible to ensure no issues. > >> >> > > >> > >> >> > > >> -- > >> >> > > >> Jacques Nadeau > >> >> > > >> CTO and Co-Founder, Dremio > >> >> > > >> > >> >> > > >> On Wed, Dec 2, 2015 at 11:52 AM, Venki Korukanti < > >> >> > > >> venki.koruka...@gmail.com> > >> >> > > >> wrote: > >> >> > > >> > >> >> > > >> > Sure, we can include DRILL-4124. I will merge it soon. Any > idea > >> >> when > >> >> > > the > >> >> > > >> > following JIRAs are going to be ready to commit? > >> >> > > >> > > >> >> > > >> > DRILL-4109 (in review) > >> >> > > >> > DRILL-4125 > >> >> > > >> > DRILL-4145 (in review) > >> >> > > >> > > >> >> > > >> > Jinfeng and I discussed about including metastore caching > and > >> >> > decided > >> >> > > to > >> >> > > >> > move it to 1.5. > >> >> > > >> > > >> >> > > >> > Lets make 5pm as the cutoff time for 1.4 branch. > >> >> > > >> > > >> >> > > >> > Thanks > >> >> > > >> > Venki > >> >> > > >> > > >> >> > > >> > On Wed, Dec 2, 2015 at 11:42 AM, Julien Le Dem < > >> >> jul...@dremio.com> > >> >> > > >> wrote: > >> >> > > >> > > >> >> > > >> > > DRILL-4124 is ready to merge: > >> >> > > >> https://github.com/apache/drill/pull/281 > >> >> > > >> > > It is a small change. > >> >> > > >> > > > >> >> > > >> > > On Wed, Dec 2, 2015 at 7:58 AM, Venki Korukanti < > >> >> > > >> > venki.koruka...@gmail.com > >> >> > > >> > > > > >> >> > > >> > > wrote: > >> >> > > >> > > > >> >> > > >> > > > I posted a comment on the commit DRILL-4126 (for some > >> reason > >> >> no > >> >> > > >> emails > >> >> > > >> > > are > >> >> > > >> > > > sent to dev list, may be because of the multiple > commits in > >> >> the > >> >> > > pull > >> >> > > >> > > > request). > >> >> > > >> > > > > >> >> > > >> > > > On Wed, Dec 2, 2015 at 7:53 AM, Jinfeng Ni < > >> >> > jinfengn...@gmail.com > >> >> > > > > >> >> > > >> > > wrote: > >> >> > > >> > > > > >> >> > > >> > > > > If the window is still open, I would like to have > >> >> DRILL-4126, > >> >> > > >> > > > > DRILL-4127 merged as well. > >> >> > > >> > > > > > >> >> > > >> > > > > Venki, could you please review the revised patch? > >> >> > > >> > > > > > >> >> > > >> > > > > > >> >> > > >> > > > > > >> >> > > >> > > > > On Wed, Dec 2, 2015 at 7:49 AM, Venki Korukanti > >> >> > > >> > > > > <venki.koruka...@gmail.com> wrote: > >> >> > > >> > > > > > Remaining JIRAs: > >> >> > > >> > > > > > > >> >> > > >> > > > > > DRILL-4109 (in review) > >> >> > > >> > > > > > DRILL-4125 > >> >> > > >> > > > > > DRILL-4145 (in review) > >> >> > > >> > > > > > > >> >> > > >> > > > > > > >> >> > > >> > > > > > On Tue, Dec 1, 2015 at 10:45 PM, Venki Korukanti < > >> >> > > >> > > > > venki.koruka...@gmail.com> > >> >> > > >> > > > > > wrote: > >> >> > > >> > > > > > > >> >> > > >> > > > > >> Sure, will merge DRILL-4111. > >> >> > > >> > > > > >> > >> >> > > >> > > > > >> On Tue, Dec 1, 2015 at 10:43 PM, Sudheesh Katkam < > >> >> > > >> > > > skat...@maprtech.com> > >> >> > > >> > > > > >> wrote: > >> >> > > >> > > > > >> > >> >> > > >> > > > > >>> Venki, can you please commit DRILL-4111? > >> >> > > >> > > > > >>> > >> >> > > >> > > > > >>> Thank you, > >> >> > > >> > > > > >>> Sudheesh > >> >> > > >> > > > > >>> > >> >> > > >> > > > > >>> > On Dec 1, 2015, at 6:22 PM, Jacques Nadeau < > >> >> > > >> jacq...@dremio.com > >> >> > > >> > > > >> >> > > >> > > > > wrote: > >> >> > > >> > > > > >>> > > >> >> > > >> > > > > >>> > It seems like we should also try to include: > >> >> > > >> > > > > >>> > > >> >> > > >> > > > > >>> > DRILL-4109 > >> >> > > >> > > > > >>> > DRILL-4125 > >> >> > > >> > > > > >>> > DRILL-4111 > >> >> > > >> > > > > >>> > > >> >> > > >> > > > > >>> > 4111 is ready to merge if someone wants to merge > >> it. > >> >> It > >> >> > > >> looks > >> >> > > >> > > like > >> >> > > >> > > > > >>> Sudheesh > >> >> > > >> > > > > >>> > just needs to commit. > >> >> > > >> > > > > >>> > > >> >> > > >> > > > > >>> > For 4125/4109, it seems like we should get > Vicki's > >> >> > > feedback > >> >> > > >> if > >> >> > > >> > > > those > >> >> > > >> > > > > >>> > changes are good for merge or if we should punt. > >> >> > > >> > > > > >>> > > >> >> > > >> > > > > >>> > > >> >> > > >> > > > > >>> > > >> >> > > >> > > > > >>> > > >> >> > > >> > > > > >>> > -- > >> >> > > >> > > > > >>> > Jacques Nadeau > >> >> > > >> > > > > >>> > CTO and Co-Founder, Dremio > >> >> > > >> > > > > >>> > > >> >> > > >> > > > > >>> > On Tue, Dec 1, 2015 at 3:59 PM, Venki Korukanti > < > >> >> > > >> > > > > >>> venki.koruka...@gmail.com> > >> >> > > >> > > > > >>> > wrote: > >> >> > > >> > > > > >>> > > >> >> > > >> > > > > >>> >> I can manage the release. > >> >> > > >> > > > > >>> >> > >> >> > > >> > > > > >>> >> Here are the pending JIRAs so far: > >> >> > > >> > > > > >>> >> > >> >> > > >> > > > > >>> >> 1) DRILL-4053 > >> >> > > >> > > > > >>> >> > >> >> > > >> > > > > >>> >> Let me know if you have any pending patches and > >> >> want to > >> >> > > get > >> >> > > >> > them > >> >> > > >> > > > > into > >> >> > > >> > > > > >>> 1.4. > >> >> > > >> > > > > >>> >> > >> >> > > >> > > > > >>> >> Thanks > >> >> > > >> > > > > >>> >> Venki > >> >> > > >> > > > > >>> >> > >> >> > > >> > > > > >>> >> On Tue, Dec 1, 2015 at 10:43 AM, Parth Chandra > < > >> >> > > >> > > par...@apache.org > >> >> > > >> > > > > > >> >> > > >> > > > > >>> wrote: > >> >> > > >> > > > > >>> >> > >> >> > > >> > > > > >>> >>> +1 on creating the release branch today. > >> >> > > >> > > > > >>> >>> I'd like to get DRILL-4053 in. Patch is ready > and > >> >> > doing > >> >> > > >> one > >> >> > > >> > > more > >> >> > > >> > > > > >>> round of > >> >> > > >> > > > > >>> >>> regression tests. > >> >> > > >> > > > > >>> >>> > >> >> > > >> > > > > >>> >>> > >> >> > > >> > > > > >>> >>> > >> >> > > >> > > > > >>> >>> On Tue, Dec 1, 2015 at 9:56 AM, Jacques > Nadeau < > >> >> > > >> > > > jacq...@dremio.com > >> >> > > >> > > > > > > >> >> > > >> > > > > >>> >> wrote: > >> >> > > >> > > > > >>> >>> > >> >> > > >> > > > > >>> >>>> It is December (already!). Seems like we > should > >> >> > create > >> >> > > a > >> >> > > >> 1.4 > >> >> > > >> > > > > release > >> >> > > >> > > > > >>> >>> branch > >> >> > > >> > > > > >>> >>>> soon so we can get a vote going. Does someone > >> >> want to > >> >> > > >> > > volunteer > >> >> > > >> > > > as > >> >> > > >> > > > > >>> the > >> >> > > >> > > > > >>> >>>> release manager? > >> >> > > >> > > > > >>> >>>> > >> >> > > >> > > > > >>> >>>> thanks, > >> >> > > >> > > > > >>> >>>> Jacques > >> >> > > >> > > > > >>> >>>> > >> >> > > >> > > > > >>> >>>> -- > >> >> > > >> > > > > >>> >>>> Jacques Nadeau > >> >> > > >> > > > > >>> >>>> CTO and Co-Founder, Dremio > >> >> > > >> > > > > >>> >>>> > >> >> > > >> > > > > >>> >>> > >> >> > > >> > > > > >>> >> > >> >> > > >> > > > > >>> > >> >> > > >> > > > > >>> > >> >> > > >> > > > > >> > >> >> > > >> > > > > > >> >> > > >> > > > > >> >> > > >> > > > >> >> > > >> > > > >> >> > > >> > > > >> >> > > >> > > -- > >> >> > > >> > > Julien > >> >> > > >> > > > >> >> > > >> > > >> >> > > >> > >> >> > > > > >> >> > > > > >> >> > > > >> >> > > >> >> > >> > > >> > > >> >
