Github user jacques-n commented on a diff in the pull request:

    https://github.com/apache/drill/pull/371#discussion_r52540911
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
 ---
    @@ -485,12 +486,14 @@ public void populatePruningVector(ValueVector v, int 
index, SchemaPath column, S
         private EndpointByteMap byteMap;
         private int rowGroupIndex;
         private String root;
    +    private long rowCount;
     
         @JsonCreator
         public RowGroupInfo(@JsonProperty("path") String path, 
@JsonProperty("start") long start,
    -        @JsonProperty("length") long length, 
@JsonProperty("rowGroupIndex") int rowGroupIndex) {
    +        @JsonProperty("length") long length, 
@JsonProperty("rowGroupIndex") int rowGroupIndex, long rowCount) {
    --- End diff --
    
    Can you add a comment that rowCount =-1 means to include all rows? 
Otherwise, LGTM +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to