Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/377#discussion_r53528079
--- Diff:
exec/java-exec/src/main/codegen/templates/DateIntervalFunctionTemplates/Extract.java
---
@@ -31,6 +31,48 @@
public class ${className} {
+/* Dummy function template to allow Optiq to validate this function call.
+ * At DrillOptiq time we rewrite all date_part() functions to extract
functions,
+ * since they are essentially the same
+ */
+@FunctionTemplate(name = "DATE_PART", scope =
FunctionTemplate.FunctionScope.SIMPLE, nulls =
FunctionTemplate.NullHandling.NULL_IF_NULL)
--- End diff --
I feel these new function implementations could be put into a separate
patch, under a different JIRA, since they are different issue (although it's
probably exposed by the function type change you made in this PR).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
