Github user jinfengni commented on a diff in the pull request:

    https://github.com/apache/drill/pull/377#discussion_r53537609
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/DummyConvertFrom.java
 ---
    @@ -32,6 +34,8 @@
     @FunctionTemplate(name = "convert_from", scope = FunctionScope.SIMPLE, 
nulls = NullHandling.NULL_IF_NULL)
     public class DummyConvertFrom implements DrillSimpleFunc {
     
    +  @Param VarCharHolder in1;
    +  @Param VarCharHolder in2;
       @Output VarBinaryHolder out;
    --- End diff --
    
    I think it's not right to put VarBinary as output type for convert_from() 
function. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to