Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/377#discussion_r53561342
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/DummyConvertTo.java
---
@@ -32,6 +34,8 @@
@FunctionTemplate(name = "convert_to", scope = FunctionScope.SIMPLE, nulls
= NullHandling.NULL_IF_NULL)
public class DummyConvertTo implements DrillSimpleFunc {
+ @Param VarCharHolder in1;
--- End diff --
Initially, I needed to add "@Param". Otherwise, validation will fail due to
failure of finding a function with the correct number of argument.
Now, with this
https://github.com/hsuanyi/incubator-drill/blob/DRILL-4372_For_Review/exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlOperator.java#L103
we can just remove this line.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
