Github user jaltekruse commented on a diff in the pull request:
https://github.com/apache/drill/pull/381#discussion_r54017535
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinProbeTemplate.java
---
@@ -47,7 +47,11 @@
private HashJoinBatch outgoingJoinBatch = null;
- private static final int TARGET_RECORDS_PER_BATCH = 4000;
+ private int targetRecordsPerBatch = 4000;
+
+ private boolean adjustTargetRecordsPerBatch = true;
--- End diff --
It looks like this flag is designed to allow the adjustment to only happen
once, is that actually what we want? If the row size is growing it would seem
like a good idea to allow for several batch size adjustments. It also removes
another boolean state to manage.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
