Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r54804039
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlOperator.java
---
@@ -18,69 +18,43 @@
package org.apache.drill.exec.planner.sql;
-import com.google.common.base.Preconditions;
-import org.apache.drill.common.types.TypeProtos.MajorType;
-import org.apache.drill.common.types.TypeProtos.MinorType;
-import org.apache.calcite.rel.type.RelDataType;
-import org.apache.calcite.rel.type.RelDataTypeFactory;
-import org.apache.calcite.sql.SqlCall;
+import java.util.ArrayList;
+import java.util.List;
+
import org.apache.calcite.sql.SqlFunction;
import org.apache.calcite.sql.SqlFunctionCategory;
import org.apache.calcite.sql.SqlIdentifier;
-import org.apache.calcite.sql.SqlOperatorBinding;
import org.apache.calcite.sql.parser.SqlParserPos;
-import org.apache.calcite.sql.type.SqlTypeName;
-import org.apache.calcite.sql.validate.SqlValidator;
-import org.apache.calcite.sql.validate.SqlValidatorScope;
+import org.apache.drill.exec.expr.fn.DrillFuncHolder;
public class DrillSqlOperator extends SqlFunction {
- static final org.slf4j.Logger logger =
org.slf4j.LoggerFactory.getLogger(DrillSqlOperator.class);
-
- private static final MajorType NONE = MajorType.getDefaultInstance();
- private final MajorType returnType;
+ // static final org.slf4j.Logger logger =
org.slf4j.LoggerFactory.getLogger(DrillSqlOperator.class);
private final boolean isDeterministic;
+ private final List<DrillFuncHolder> functions;
public DrillSqlOperator(String name, int argCount, boolean
isDeterministic) {
- this(name, argCount, MajorType.getDefaultInstance(), isDeterministic);
+ this(name, new ArrayList<DrillFuncHolder>(), argCount, argCount,
isDeterministic);
--- End diff --
I can see the legacy reason for such code. For now, it's fine to leave it
as is. But we need open JIRA as a follow-up work to clean this legacy code. We
should not create DrillSqlOperator using this constructor; in stead, it should
go through DrillOperatorTable to find the registered one. Otherwise, there
would be two versions of DrillSqlOperators for "castHigh". One is the normally
registered, the other one is the one created internally. Such different version
would potentially cause problem down the road. We should clean up those legacy
code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
