Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/406#discussion_r55421789
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/ConvertCountToDirectScan.java
---
@@ -103,6 +104,10 @@ public void onMatch(RelOptRuleCall call) {
return;
}
+ if (proj != null && !ProjectRemoveRule.isTrivial(proj)) {
--- End diff --
I feel that this check might over-kill some optimization opportunity. For
example,
select count(100)
from `parquetTable`;
In this case, count(100) is equal to rowcount in parquet table. However,
the project is not a trial project, meaning the new code will disable the
optimization.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
