Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/397#discussion_r56426878 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillOperatorTable.java --- @@ -26,34 +33,88 @@ import org.apache.calcite.sql.SqlOperatorTable; import org.apache.calcite.sql.SqlSyntax; import org.apache.calcite.sql.fun.SqlStdOperatorTable; +import org.apache.drill.exec.planner.physical.PlannerSettings; +import org.apache.drill.exec.server.options.SystemOptionManager; import java.util.List; +import java.util.Map; +/** + * Implementation of {@link SqlOperatorTable} that contains standard operators and functions provided through + * {@link #inner SqlStdOperatorTable}, and Drill User Defined Functions. + */ public class DrillOperatorTable extends SqlStdOperatorTable { - static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(DrillOperatorTable.class); - +// private static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(DrillOperatorTable.class); private static final SqlOperatorTable inner = SqlStdOperatorTable.instance(); - private List<SqlOperator> operators; - private ArrayListMultimap<String, SqlOperator> opMap = ArrayListMultimap.create(); + private final List<SqlOperator> operatorsCalcite = Lists.newArrayList(); --- End diff -- Nits: better names for these variables?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---