Github user jaltekruse commented on a diff in the pull request:
https://github.com/apache/drill/pull/524#discussion_r67415245
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/ischema/InfoSchemaFilterBuilder.java
---
@@ -73,9 +73,12 @@ public ExprNode visitFunctionCall(FunctionCall call,
Void value) throws RuntimeE
case "like": {
ExprNode arg0 = call.args.get(0).accept(this, value);
ExprNode arg1 = call.args.get(1).accept(this, value);
+ ExprNode arg2 = call.args.size() > 2 ?
call.args.get(2).accept(this, value) : null;
--- End diff --
do you want to update these variables to have meaningful names about what
each of the arguments will be used for like you did above? Would make it a
little clearer why the ternary is only needed in the last case because the
escape is the only optional parameter.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
