Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/531#discussion_r68161349
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/store/TestImplicitFileColumns.java
---
@@ -110,4 +111,20 @@ public void testImplicitColumnsForParquet() throws
Exception {
.go();
}
+ @Test // DRILL-4733
+ public void testMultilevelParquetWithSchemaChange() throws Exception {
+ try {
+ test("alter session set `planner.enable_decimal_data_type` = true");
+ testBuilder()
+ .sqlQuery(String.format("select max(dir0) as max_dir from
dfs_test.`%s/src/test/resources/multilevel/parquetWithSchemaChange`",
+ TestTools.getWorkingPath()))
+ .unOrdered()
+ .baselineColumns("max_dir")
+ .baselineValues("voter50.parquet")
--- End diff --
It does seem confusing to have the .parquet extension to the folder name.
Could you change it and update the pull request ?
Perf tests look good so far.
+1 on the patch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
