Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/549#discussion_r72131382
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/DrillCompoundIdentifier.java
---
@@ -69,31 +70,38 @@ public void addIndex(int index, SqlParserPos pos){
}
}
- public SqlNode getAsSqlNode(){
- if(ids.size() == 1){
+ public SqlNode getAsSqlNode(Set<DrillCompoundIdentifier> fullSchemasSet)
{
--- End diff --
It would be great don't convert original calcite `SqlNode` with
`CompoundIdentifierConverter`.
In that case unit tests from my PR would have passed successfully but drill
functionality with nested complex schema wouldn't work (ex: quering json
arrays). So I think we can't refuse from `DrillParserWithCompoundIdConverter`
logic.
And the main idea of this PR to improve that CompoundIdentifierConverter
don't ignore full schema in the beginning of the identifier.
If I missed something please correct me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
