Jinfeng, Please see my new commit & comment in PR 517. I attached debugger to Drill and found it's passing through line 172 (not 315-316) of ExpressionTreeMaterializer.java, and that the "toType" object is one of those runtime generated ones (name like TypeProtos$MajorType@8570). Rather than attempt to change that code, I made another change to CastIntDecimal.java which avoids repeated calculation of the precision when it is already provided. Please review.
Dave Oshinsky -----Original Message----- From: Jinfeng Ni [mailto:jinfengn...@gmail.com] Sent: Wednesday, August 03, 2016 7:18 PM To: dev Subject: Re: Time for a 1.8 release I put a comment in PR 517. On Wed, Aug 3, 2016 at 3:09 PM, Jinfeng Ni <jinfengn...@gmail.com> wrote: > Although decimal type is listed as alpha feature for Drill[1] and not > recommend for production use, it is important to fix the incorrect > issues such as the one reported in DRILL-4704. > > Let me take a quick look at your PR and see if it's ready to be merged. > > [1] https://drill.apache.org/docs/supported-data-types/ > > > On Wed, Aug 3, 2016 at 11:55 AM, Dave Oshinsky <doshin...@commvault.com> > wrote: >> Can we try to get this one (in play since shortly before 1.7 release) into >> 1.8? >> https://github.com/apache/drill/pull/517 >> >> Aman Sinha was reviewing it, but that seemed to stall. As a general >> question, is there any priority on making decimal types work better? If >> yes, a DRILL-4704 fix would be a very small start. >> >> Dave Oshinsky >> >> -----Original Message----- >> From: Jinfeng Ni [mailto:jinfengn...@gmail.com] >> Sent: Wednesday, August 03, 2016 2:49 PM >> To: dev >> Subject: Re: Time for a 1.8 release >> >> I would like to propose we set Monday 8/8 as the tentative cut-off date for >> 1.8 release. >> >> If people have any working-in-progress patches, and would like to include in >> 1.8 release, please submit PR, or ping people to review your PR if there has >> been a PR under review. >> >> Thanks, >> >> >> >> >> On Tue, Aug 2, 2016 at 3:00 PM, Jinfeng Ni <jinfengn...@gmail.com> wrote: >>> Hello everyone, >>> >>> I would like to start the train for 1.8 release. >>> >>> If you have been working on some open issues, and want to include >>> them in 1.8, please rely this email and let us know the JIRAs number >>> and corresponding pull requests. >>> >>> Based on the response, we may go through the list of opens JIRAs >>> for 1.8, and come up with a tentatively cut-off date for 1.8 release. >>> >>> Thanks, >>> >>> >>> >>> On Tue, Aug 2, 2016 at 2:14 PM, Aditya <a...@apache.org> wrote: >>>> +1 for Jinfeng as the RM for 1.8 release. >>>> >>>> On Tue, Aug 2, 2016 at 11:59 AM, Jinfeng Ni <jinfengn...@gmail.com> wrote: >>>> >>>>> I'll volunteer to be the release manager for 1.8, if no one else >>>>> would like to do so. >>>>> >>>>> >>>>> >>>>> >>>>> On Mon, Aug 1, 2016 at 9:40 PM, Parth Chandra <par...@apache.org> wrote: >>>>> > Hi Everyone, >>>>> > >>>>> > I think its time to roll out 1.8. Would any PMC >>>>> > member/committer >>>>> like >>>>> > to volunteer to be the release manager? >>>>> > >>>>> > Parth >>>>> >>
