Hi Jean-Claude, Thanks for the PR. I started taking a look but will have to spend some time on making sure the evaluationVisitor change is good.
Also, it looks like you might have pushed another commit to the same branch and the PR has got an unrelated change. I'll assume that (acd08439873f935b5eabebe32dae4af87b9e97db) is the relevant commit. Parth On Wed, Sep 14, 2016 at 8:02 PM, Jean-Claude Cote <[email protected]> wrote: > Please review DRILL-4858 > > On Tue, Sep 6, 2016 at 6:49 PM, Jean-Claude Cote <[email protected]> wrote: > > > ok let me know when you do so. > > > > On Fri, Sep 2, 2016 at 12:03 AM, Jinfeng Ni <[email protected]> wrote: > > > >> Thanks for submitting the PR for that issue. I'll take a look at the > PR. > >> > >> On Thu, Sep 1, 2016 at 6:36 PM, Jean-Claude Cote <[email protected]> > >> wrote: > >> > Please > >> > > > > >
