Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/597#discussion_r81245030
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
@@ -864,6 +872,14 @@ public String getDigest() {
return toString();
}
+ public void setCacheFileRoot(String cacheFileRoot) {
+ this.cacheFileRoot = cacheFileRoot;
+ }
+
+ public void setBatchSize(long batchSize) {
+ this.recommendedBatchSize = batchSize;
--- End diff --
I feel it's fine we do not have such check. Max value for option is
checked when users tries "alter session set" command.
For "limit n" query where n is > max value, ParquetRecordReader would pick
min of two values, essentially ignore this recommendedBatchSize (?).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---