Github user chunhui-shi commented on a diff in the pull request:
https://github.com/apache/drill/pull/594#discussion_r81617585
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java
---
@@ -131,14 +139,33 @@ public void ensureAtLeastOneField(ComplexWriter
writer) {
PathSegment fieldPath = fieldPathList.get(j);
if (emptyStatus.get(j)) {
if (allTextMode) {
- fieldWriter.varChar(fieldPath.getNameSegment().getPath());
+ if (checkNullFields(fieldPathList)) {
+ for (String fieldName : nullableFields) {
+ fieldWriter.varChar(fieldName);
+ }
+ } else {
+ fieldWriter.varChar(fieldPath.getNameSegment().getPath());
+ }
} else {
- fieldWriter.integer(fieldPath.getNameSegment().getPath());
+ if (checkNullFields(fieldPathList)) {
--- End diff --
Your fix is not targeted to change behavior under non-allTextMode, right?
If this is the case, is this change in "else" needed? If you want to fix
behavior under non-allTextMode as well, then you should also add unit test for
this mode as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
