Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/626#discussion_r84378620
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/ZKClusterCoordinator.java
---
@@ -158,10 +158,14 @@ public void cacheChanged() {
}
}
+ @Override
public void close() throws Exception {
- // discovery attempts to close its caches(ie serviceCache) already.
however, being good citizens we make sure to
- // explicitly close serviceCache. Not only that we make sure to close
serviceCache before discovery to prevent
- // double releasing and disallowing jvm to spit bothering warnings.
simply put, we are great!
+ // discovery attempts to close its caches(ie serviceCache) already.
however,
--- End diff --
What's changed in the comment? Formatting?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
