Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/560#discussion_r86382118
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentContext.java ---
@@ -445,11 +447,16 @@ public PartitionExplorer getPartitionExplorer() {
}
@Override
- public ValueHolder getConstantValueHolder(String value,
Function<DrillBuf, ValueHolder> holderInitializer) {
- ValueHolder valueHolder = constantValueHolderCache.get(value);
+ public ValueHolder getConstantValueHolder(String value, MinorType type,
Function<DrillBuf, ValueHolder> holderInitializer) {
--- End diff --
it would be nice if we could share the common codes of
getConstantValueHolder() in QueryContext/FragmentContext, and wrap them in a
helper function. But this is optional.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
