Github user harrisonmebane commented on a diff in the pull request:
https://github.com/apache/drill/pull/647#discussion_r86856157
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/service/ServiceEngine.java
---
@@ -142,7 +142,13 @@ private static BufferAllocator newAllocator(
public DrillbitEndpoint start() throws DrillbitStartupException,
UnknownHostException{
int userPort =
userServer.bind(config.getInt(ExecConstants.INITIAL_USER_PORT),
allowPortHunting);
- String address = useIP ? InetAddress.getLocalHost().getHostAddress()
: InetAddress.getLocalHost().getCanonicalHostName();
+ String configIP = config.getString(ExecConstants.BIT_ADVERTISED_HOST);
+ String address = null;
+ if (configIP == "") {
--- End diff --
Good suggestion! Much cleaner.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
