Github user sohami commented on a diff in the pull request:

    https://github.com/apache/drill/pull/648#discussion_r87120245
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java ---
    @@ -223,19 +223,65 @@ public void connect(Properties props) throws 
RpcException {
         connect(null, props);
       }
     
    +  /**
    +   * Function to populate the endpointList with information of all the 
drillbits
    +   * provided in the connection string by client
    +   * @param endpointList - ArrayList of DrillbitEndpoints
    +   * @param drillbits - One or more drillbit ip[:port] provided in 
connection string
    --- End diff --
    
    @kkhatua - I am not sure if I followed fully. This is an internal method 
parameter and is not changing the name of "drillbit" parameter in connection 
string. So it should not have any doc impact.
    @paul-rogers - I am not introducing anything new here. The 
[documentation](http://drill.apache.org/docs/using-the-jdbc-driver/#using-the-jdbc-url-format-for-a-direct-drillbit-connection)
 already specifies the usage but the correct implementation was lacking. It 
also says we only support one port (user port) as is the case with zk.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to