Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/666#discussion_r90698347
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/SqlHandlerUtil.java
 ---
    @@ -235,4 +235,15 @@ public static void unparseSqlNodeList(SqlWriter 
writer, int leftPrec, int rightP
         writer.keyword(")");
       }
     
    +  /**
    +   * Generates temporary table name using original table and unique 
identifies.
    +   *
    +   * @param tableName original table name
    +   * @param uuid unique identifier
    +   * @return generated temporary table name
    +   */
    +  public static String generateTemporaryTableName(String tableName, String 
uuid) {
    --- End diff --
    
    Generates a unique name. But, now the table name on disk will differ from 
the table name that the user defined. Does the code handle this case: knows to 
look in a registry to translate from one to the other? Would it be simpler to 
create a subdirectory with uuid, and put all the tables for a session in that 
directory with their original name?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to