Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/660#discussion_r93133574
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/compile/AbstractClassCompiler.java
---
@@ -74,9 +76,10 @@ protected String prefixLineNumbers(String code) {
return out.toString();
}
- protected abstract byte[][] getByteCode(ClassNames className, String
sourcecode)
+ protected abstract byte[][] getByteCode(final ClassNames className,
final String sourcecode)
throws CompileException, IOException, ClassNotFoundException,
ClassTransformationException;
-
+ public abstract Map<String,byte[]> compile(final ClassNames className,
final String sourceCode)
--- End diff --
We spoke in person. There was some confusion about the two caches involved.
One is the original class cache, which has not changed. This is a way for the
compiler to give us a (name, code) map so we can match up byte codes to
compiled code. This map is used only after the global class cache has decided
we have a cache miss.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
