Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/713#discussion_r95100719
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java
---
@@ -59,6 +59,12 @@
private final boolean readNumbersAsDouble;
/**
+ * Collection for tracking empty array writers during reading
+ * and storing them for initializing empty arrays
+ */
+ private final Set<ListWriter> emptyArrayWritersSet = Sets.newHashSet();
--- End diff --
Any reason why this needs to be HashSet rather than just a List ? The
HashSet may change the insertion order, so if you had 2 or more empty arrays in
the same Json doc within one list, the output of Flatten could end up changing
the order.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
