Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/719#discussion_r95436174
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
 ---
    @@ -105,6 +109,25 @@ public String getTime() {
           return format.format(time);
         }
     
    +    public long getStartTime() {
    +      return startTime;
    +    }
    +
    +    public long getEndTime() {
    +      return endTime;
    +    }
    +
    +    public String getDuration() {
    --- End diff --
    
    How about we create wrapper class around `QueryProfile` (ex: 
`QueryProfileWrapper`) which will contain `getDuration` method along with 
needed `QueryProfile` methods. Logic for converting two long values (start and 
end) into human-readable format will be factored out into static method in 
`ProfileResources` (ex: `convertDurationIntoString(long start, long end)`). 
`QueryProfileWrapper` and `ProfileResources` will call this utility method from 
their `getDuration` methods.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to