Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/685#discussion_r97449967
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/ContextFunctions.java
---
@@ -64,17 +65,45 @@ public void eval() {
@Inject DrillBuf buffer;
@Workspace int currentSchemaBytesLength;
+ @Override
public void setup() {
final byte[] currentSchemaBytes =
contextInfo.getCurrentDefaultSchema().getBytes();
buffer = buffer.reallocIfNeeded(currentSchemaBytes.length);
currentSchemaBytesLength= currentSchemaBytes.length;
buffer.setBytes(0, currentSchemaBytes);
}
+ @Override
public void eval() {
out.start = 0;
out.end = currentSchemaBytesLength;
out.buffer = buffer;
}
}
+
+ /**
+ * Implement "session_id" function. Returns the unique id of the current
session.
+ */
+ @FunctionTemplate(name = "session_id", scope =
FunctionTemplate.FunctionScope.SIMPLE, isNiladic = true)
--- End diff --
I thought this new introduced flag "isNiladic" should not only applied to
this new "session_id" function, but also for all the existing functions which
falls into same category, for example, current_date /current_time?
1.
https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/DateTypeFunctions.java#L234
2.
https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/DateTypeFunctions.java#L290
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
