Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/739#discussion_r99385729
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/TableBuilder.java
---
@@ -78,29 +93,8 @@ public void appendTime(final long d, final String link) {
}
public void appendMillis(final long p, final String link) {
- final double secs = p/1000.0;
- final double mins = secs/60;
- final double hours = mins/60;
- final double days = hours / 24;
- SimpleDateFormat timeFormat = null;
- if (days >= 10) {
- timeFormat = this.days;
- } else if (days >= 1) {
- timeFormat = this.sdays;
- } else if (hours >= 10) {
- timeFormat = this.hours;
- }else if(hours >= 1){
- timeFormat = this.shours;
- }else if (mins >= 10){
- timeFormat = this.mins;
- }else if (mins >= 1){
- timeFormat = this.smins;
- }else if (secs >= 10){
- timeFormat = this.secs;
- }else {
- timeFormat = this.ssecs;
- }
- appendCell(timeFormat.format(new Date(p)), null);
+ String shortReadableDuration = shortDurationFormat(p);
+ appendCell(shortReadableDuration, link);
--- End diff --
In Drill, we like brevity:
```
appendCell(shortDurationFormat(p), link);
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
