Github user kkhatua commented on a diff in the pull request:

    https://github.com/apache/drill/pull/751#discussion_r101910087
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
 ---
    @@ -220,7 +225,21 @@ public QProfiles getProfilesJSON() {
     
           final List<ProfileInfo> finishedQueries = Lists.newArrayList();
     
    -      final Iterator<Map.Entry<String, QueryProfile>> range = 
completed.getRange(0, MAX_PROFILES);
    +      //Defining #Profiles to load
    +      int maxProfilesToLoad;
    +      if (MaxProfiles == null) {
    +        MaxProfiles = 
work.getContext().getConfig().getInt(ExecConstants.HTTP_MAX_PROFILES);
    --- End diff --
    
    I wasn't sure if I'd want to repeatedly load the value from the config 
object, as I was assuming it might have synchronized access. But considering 
this is not going to be called at a very high frequency, there shouldn't be any 
overhead. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to