Github user ppadma commented on a diff in the pull request:
https://github.com/apache/drill/pull/747#discussion_r102277543
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
@@ -413,4 +413,19 @@
String DYNAMIC_UDF_SUPPORT_ENABLED = "exec.udf.enable_dynamic_support";
BooleanValidator DYNAMIC_UDF_SUPPORT_ENABLED_VALIDATOR = new
BooleanValidator(DYNAMIC_UDF_SUPPORT_ENABLED, true, true);
+
+ /**
+ * Option to save query profiles.
+ * <ul>
+ * <li>async (default): Write query profile after last response
+ * to the client.</li>
+ * <li>sync: Write the query profile before the last response to
+ * the client. Very useful for testing to avoid race conditions.</li>
+ * <li>none: Don't write the query profile at all. Useful when running
+ * many production jobs that do not need to be reviewed.</li>
+ * </ul>
+ */
+ String QUERY_PROFILE_OPTION = "exec.profile";
--- End diff --
exec.query_profile.write_mode might be a better choice for clarity.
Also, would it be better to have two options ?
boolean: exec.query_profile.write_enabled and exec.query_profile.write_mode
(sync or async).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
