Github user ppadma commented on a diff in the pull request:
https://github.com/apache/drill/pull/757#discussion_r102611281
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
@@ -413,4 +413,8 @@
String DYNAMIC_UDF_SUPPORT_ENABLED = "exec.udf.enable_dynamic_support";
BooleanValidator DYNAMIC_UDF_SUPPORT_ENABLED_VALIDATOR = new
BooleanValidator(DYNAMIC_UDF_SUPPORT_ENABLED, true, true);
+
+ String USE_DYNAMIC_UDFS = "exec.udf.use_dynamic";
--- End diff --
I did not use the existing option "exec.udf.enable_dynamic_support" because
if that option is enabled and then disabled later, expectation is that dynamic
UDFs added in that window continue to be available and working even after
disabling.
All other comments addressed. Please review new diffs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
