[GitHub] drill pull request #756: DRILL-5195: Publish Operator and MajorFragment Stat...

[paul-rogers]

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/756#discussion_r102807297
  
    --- Diff: exec/java-exec/src/main/resources/rest/profile/profile.ftl ---
    @@ -107,6 +107,9 @@
       <p>FOREMAN: ${model.getProfile().getForeman().getAddress()}</p>
       <p>TOTAL FRAGMENTS: ${model.getProfile().getTotalFragments()}</p>
       <p>DURATION: ${model.getProfileDuration()}</p>
    +  <p>&nbsp;&nbsp;&nbsp;&nbsp;PLANNING: ${model.getPlanningDuration()}</p>
    +  <p>&nbsp;&nbsp;&nbsp;&nbsp;QUEUED: ${model.getQueuedDuration()}</p>
    +  <p>&nbsp;&nbsp;&nbsp;&nbsp;EXECUTION: ${model.getExecutionDuration()}</p>
    --- End diff --
    
    Thanks for the indent. But, using nbsp is old-school. Please create a style 
that sets the left margin to, say 4em.
    
    Also, as long as we are here, might as well clean up the labels. Shift from 
UPPER CASE to Title Case.
    
    And, for extra credit, change the whole mess to a table so that the values 
are all aligned in a nice column.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---