Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/761#discussion_r103068736
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java
---
@@ -948,50 +1027,50 @@ private void updateMemoryEstimates(long memoryDelta,
RecordBatchSizer sizer) {
// spill batches of either 64K records, or as many records as fit into
the
// amount of memory dedicated to each spill batch, whichever is less.
- spillBatchRowCount = (int) Math.max(1, spillBatchSize /
estimatedRowWidth);
+ spillBatchRowCount = (int) Math.max(1, preferredSpillBatchSize /
estimatedRowWidth / 2);
--- End diff --
This factor of 2 seems extremely cautious; we may pay a little in
performance every time, just for that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
