Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/772#discussion_r104606833
--- Diff: contrib/native/client/src/clientlib/zookeeperClient.cpp ---
@@ -138,6 +138,11 @@ int ZookeeperClient::getAllDrillbits(const
std::string& connectStr, std::vector<
DRILL_MT_LOG(DRILL_LOG(LOG_TRACE) << "\t Unshuffled Drillbit
id: " << drillbits[i] << std::endl;)
}
}
+ else{
--- End diff --
Agreed. Should be handled in caller (i.e. DrillClient). If the returned
vector size is zero then we should check that in DrillClient and close client
connection with error as `ERR_CONN_ZKNODBIT`. Something like below:
`return handleConnError(CONN_INVALID_INPUT, getMessage(ERR_CONN_ZKNODBIT,
pathToDrill.c_str()));`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
