Github user jinfengni commented on a diff in the pull request:

    https://github.com/apache/drill/pull/775#discussion_r104802660
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/work/metadata/ServerMetaProvider.java
 ---
    @@ -76,7 +76,7 @@
           .setReadOnly(false)
           .setGroupBySupport(GroupBySupport.GB_UNRELATED)
           .setLikeEscapeClauseSupported(true)
    -      .setNullCollation(NullCollation.NC_AT_END)
    +      .setNullCollation(NullCollation.NC_HIGH)
    --- End diff --
    
    I'm not completely sure why we should change from NC_AT_END to NC_HIGH, in 
stead of NC_AT_END.  I thought Drill is using ASC as default ordering, and 
NULLS LAST as default null collation for ASC. This is consistent to what Oracle 
[1] and Postgres [2] is doing : ASC /NULL LAST is the default option.  
    
    1. http://docs.oracle.com/javadb/10.6.2.1/ref/rrefsqlj13658.html
    2. https://www.postgresql.org/docs/9.4/static/queries-order.html



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to