Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/792#discussion_r107922769
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/compile/TestEvaluationVisitor.java
---
@@ -72,6 +73,37 @@ public void x() throws Exception{
logger.debug(g.generateAndGet());
}
+ @Test
+ public void testVisitBooleanOrWithoutFunctionsEvaluation() throws
Exception {
--- End diff --
How about move the new testcase into TestBugFixes? The new testcases uses
SQL, while the existing one in TestEvaluationVisitor actually tests in a lower
level. Probably better to not mix them together.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
