Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/795#discussion_r108050603
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/SqlConverter.java
---
@@ -107,26 +110,51 @@ public SqlConverter(QueryContext context) {
this.sqlToRelConverterConfig = new SqlToRelConverterConfig();
this.isInnerQuery = false;
this.typeFactory = new JavaTypeFactoryImpl(DRILL_TYPE_SYSTEM);
- this.defaultSchema = context.getNewDefaultSchema();
- this.rootSchema = rootSchema(defaultSchema);
+
+ this.defaultSchema = context.getPartialDefaultSchema();
--- End diff --
All these "this." prefixes are not needed. "this." is used only when member
names are the same as argument names:
```
public Foo(String name) {
this.name = name;
}
```
In this case, a reader has to double check: what is the difference between
`this.defaultSchema` and `defaultSchema`? Turns out, they are the same, so we
should use the same form of reference everywhere in the ctor.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
