Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/704#discussion_r109051708
--- Diff: exec/vector/src/main/codegen/templates/NullableValueVectors.java
---
@@ -374,6 +374,19 @@ public void copyFromSafe(int fromIndex, int thisIndex,
Nullable${minor.class}Vec
values.copyFromSafe(fromIndex, thisIndex, from.values);
}
+ @Override
+ public void copyEntry(int toIndex, ValueVector from, int fromIndex) {
+ Nullable${minor.class}Vector fromVector =
(Nullable${minor.class}Vector) from;
+ <#if type.major == "VarLen">
+
+ // This method is to be called only for loading the vector
+ // sequentially, so there should be no empties to fill.
+
+ </#if>
+ bits.copyFromSafe(fromIndex, toIndex, fromVector.bits);
+ values.copyFromSafe(fromIndex, toIndex, fromVector.values);
--- End diff --
IntVector.copyEntry() will call DrillBuf.getBytes(....), yet
NullableIntVector.copyEntry() will call IntVector.copyFromSafe() which seems to
go through different code path. Is there a reason for such difference?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
