Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/773#discussion_r109742481
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/AbstractServerConnection.java
---
@@ -110,7 +130,31 @@ public void changeHandlerTo(final RequestHandler<S>
handler) {
}
@Override
- public void close() {
+ public void setEncrypted(boolean encrypted){
+ throw new UnsupportedOperationException("Changing encryption setting
on server connection is not permitted.");
+ }
+
+ @Override
+ public void setWrappedChunkSize(int chunkSize) {
+ throw new UnsupportedOperationException("Changing WrappedChunkSize
setting on server connection is not permitted.");
+ }
+
+
+ @Override
+ public void incConnectionCounter() {
+ config.incConnectionCounter(isEncrypted());
+ }
+
+ @Override
+ public void decConnectionCounter() {
+ config.decConnectionCounter(isEncrypted());
+ }
+
+ @Override
+ public void channelClosed(RpcException ex) {
+ // This will be triggered from Netty when a channel is closed. We
should cleanup here
--- End diff --
nice catch
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
