Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/773#discussion_r111651798
--- Diff:
exec/rpc/src/main/java/org/apache/drill/exec/rpc/AbstractRemoteConnection.java
---
@@ -224,4 +237,67 @@ public void close() {
}
}
+ /**
+ * Helps to add all the required security handler's after negotiation
for encryption is completed.
+ * <p>
+ * Handler's that are added are:
+ * <li> SaslDecryptionHandler
+ * <li> LengthFieldBasedFrameDecoder Handler
+ * <li> SaslEncryptionHandler
+ * <li> ChunkCreationHandler
+ * </p>
+ * <p>
+ * If encryption is enabled ChunkCreationHandler is always added
irrespective of chunkMode enabled or not.
+ * This helps to make a generic encryption handler.
+ * </p>
+ */
+ @Override
+ public void addSecurityHandlers() {
+
+ final ChannelPipeline channelPipeline = getChannel().pipeline();
+ channelPipeline.addFirst("SaslDecryptionHandler", new
SaslDecryptionHandler(saslBackend, getWrappedChunkSize(),
--- End diff --
Moved all the handlers names as part of RpcConstants and using that in
BasicClient/BasicServer as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
