Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/773#discussion_r111646441
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/security/AuthenticationOutcomeListener.java
---
@@ -120,19 +121,22 @@ public void success(SaslMessage value, ByteBuf
buffer) {
new SaslException("Server sent a corrupt message.")));
} else {
try {
- final SaslChallengeContext context = new
SaslChallengeContext(value, connection.getSaslClient(), ugi);
-
+ final SaslChallengeContext<C> context = new
SaslChallengeContext<>(value, ugi, connection);
final SaslMessage saslResponse = processor.process(context);
if (saslResponse != null) {
client.send(new AuthenticationOutcomeListener<>(client,
connection, saslRpcType, ugi, completionListener),
connection, saslRpcType, saslResponse, SaslMessage.class,
- true /** the connection will not be backed up at this point
*/);
+ true /* the connection will not be backed up at this point
*/);
} else {
// success
completionListener.success(null, null);
+ logger.trace("Successfully authenticated to server using {}
mechanism and encryption context: {}",
--- End diff --
trying to understand why this check is needed here ? Whereas other places
we just end up using logger.trace as is ? E.g: above `logger.trace("Initiated
SASL exchange")`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
