Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/819#discussion_r113605799
  
    --- Diff: common/src/main/java/org/apache/drill/common/types/Types.java ---
    @@ -340,18 +344,18 @@ public static int getJdbcDisplaySize(MajorType type) {
         case INTERVALYEAR:
           return precision > 0
               ? 5 + precision // P..Y12M
    -          : 0; // if precision is not set, return 0 because there's not 
enough info
    +          : UNDEFINED; // if precision is not set, return 0 because 
there's not enough info
     
         case INTERVALDAY:
           return precision > 0
               ? 12 + precision // P..DT12H60M60S assuming fractional seconds 
precision is not supported
    -          : 0; // if precision is not set, return 0 because there's not 
enough info
    +          : UNDEFINED; // if precision is not set, return 0 because 
there's not enough info
    --- End diff --
    
    We know that an interval of days must fit into a 12-byte field. I think the 
encoding is 4 bytes for days, 8 for ms. So, maximum width can be computed from 
that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to